Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Get rid of unnecessary snodes map in Program class. #3234

Merged
merged 1 commit into from
Oct 20, 2021
Merged

[refactor] Get rid of unnecessary snodes map in Program class. #3234

merged 1 commit into from
Oct 20, 2021

Conversation

ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Oct 20, 2021 •
edited
Loading

Found this issue while reading snode tree related code :P
It mainly does two things:

  1. Get rid of snode map in program class, we seem to use it in async engine and llvm cpu backend but it's not necessary.
  2. Somehow we compile struct on both device and host when arch is cuda (in LlvmProgramImpl::materialize_snode_tree), it turns out to be redundant as well.

@netlify
Copy link

netlify bot commented Oct 20, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: a4cf4d4

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/616fe2b22501d000080193c8

k-ye
k-ye approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit 6538f34 into taichi-dev:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ailzhang @k-ye